From: Sergey Shtylyov Date: Wed, 17 Dec 2025 20:21:43 +0000 (+0300) Subject: crypto: drbg - kill useless variable in drbg_fips_continuous_test() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eb6449aa7b32259a8b59e0c9602b32dcaf1fba58;p=thirdparty%2Fkernel%2Flinux.git crypto: drbg - kill useless variable in drbg_fips_continuous_test() In drbg_fips_continuous_test(), not only the initializer of the ret local variable is useless, the variable itself does not seem needed as it only stores the result of memcmp() until it's checked on the next line -- get rid of the variable... Signed-off-by: Sergey Shtylyov Signed-off-by: Herbert Xu --- diff --git a/crypto/drbg.c b/crypto/drbg.c index 1d433dae99557..ab7da601a87fa 100644 --- a/crypto/drbg.c +++ b/crypto/drbg.c @@ -234,7 +234,6 @@ static int drbg_fips_continuous_test(struct drbg_state *drbg, const unsigned char *entropy) { unsigned short entropylen = drbg_sec_strength(drbg->core->flags); - int ret = 0; if (!IS_ENABLED(CONFIG_CRYPTO_FIPS)) return 0; @@ -253,8 +252,7 @@ static int drbg_fips_continuous_test(struct drbg_state *drbg, /* priming: another round is needed */ return -EAGAIN; } - ret = memcmp(drbg->prev, entropy, entropylen); - if (!ret) + if (!memcmp(drbg->prev, entropy, entropylen)) panic("DRBG continuous self test failed\n"); memcpy(drbg->prev, entropy, entropylen);