From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 13 Mar 2025 12:03:02 +0000 (+0100)
Subject: ch: Rework virCHProcessConnectMonitor()
X-Git-Tag: v11.2.0-rc1~144
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eb6c28408d0e7d982607e1a0c55432ab30a0caca;p=thirdparty%2Flibvirt.git

ch: Rework virCHProcessConnectMonitor()

Firstly, let's switch from explicit virCHDriverGetConfig() +
virObjectUnref() combo to g_autoptr(virCHDriverConfig). This
leaves us with the @monitor variable which is initialized to NULL
only to be then set to the retval of virCHMonitorNew() and
returned instantly. Well, the variable is now useless and can be
dropped.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c
index 79f5990cc1..ee86430e08 100644
--- a/src/ch/ch_process.c
+++ b/src/ch/ch_process.c
@@ -53,13 +53,9 @@ virCHProcessConnectMonitor(virCHDriver *driver,
                            virDomainObj *vm,
                            int logfile)
 {
-    virCHMonitor *monitor = NULL;
-    virCHDriverConfig *cfg = virCHDriverGetConfig(driver);
-
-    monitor = virCHMonitorNew(vm, cfg, logfile);
+    g_autoptr(virCHDriverConfig) cfg = virCHDriverGetConfig(driver);
 
-    virObjectUnref(cfg);
-    return monitor;
+    return virCHMonitorNew(vm, cfg, logfile);
 }
 
 static void