From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 29 Jun 2011 09:09:07 +0000 (+0200)
Subject: Disallow pings for TCP sockets
X-Git-Tag: release_3_0_0_beta0~744
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eb7be0aeec46da27eaa7dcc4a850fe14c7471085;p=thirdparty%2Ffreeradius-server.git

Disallow pings for TCP sockets

The existing UDP ping code assumes that any socket can send to any
server.  This isn't true for TCP sockets.  For them, the pings
have to be specific to each socket.

The RFC 3539 Status-Server watchdog code will fix that.
---

diff --git a/src/main/realms.c b/src/main/realms.c
index 3727c78436e..d5286ff1123 100644
--- a/src/main/realms.c
+++ b/src/main/realms.c
@@ -628,9 +628,9 @@ static int home_server_add(realm_config_t *rc, CONF_SECTION *cs)
 			hs_proto = NULL;
 			home->proto = IPPROTO_TCP;
 			
-			if (home->ping_check == HOME_PING_CHECK_REQUEST) {
+			if (home->ping_check != HOME_PING_CHECK_NONE) {
 				cf_log_err(cf_sectiontoitem(cs),
-					   "Cannot use 'status_check = request' for home servers where 'proto = tcp'");
+					   "Only 'status_check = none' is allowed for home servers with 'proto = tcp'");
 				goto error;
 			}