From: Havoc Pennington <hp@redhat.com>
Date: Tue, 19 Jun 2007 17:23:55 +0000 (+0000)
Subject: add a comment about the match rules limit
X-Git-Tag: dbus-1.1.2~56
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebb99420e577a0760e36ed38556aa833ace24996;p=thirdparty%2Fdbus.git

add a comment about the match rules limit
---

diff --git a/bus/config-parser.c b/bus/config-parser.c
index 7b6a368cf..d557a91ca 100644
--- a/bus/config-parser.c
+++ b/bus/config-parser.c
@@ -487,7 +487,15 @@ bus_config_parser_new (const DBusString      *basedir,
       
       parser->limits.max_pending_activations = 512;
       parser->limits.max_services_per_connection = 512;
-      
+
+      /* For this one, keep in mind that it isn't only the memory used
+       * by the match rules, but slowdown from linearly walking a big
+       * list of them. A client adding more than this is almost
+       * certainly a bad idea for that reason, and should change to a
+       * smaller number of wider-net match rules - getting every last
+       * message to the bus is probably better than having a thousand
+       * match rules.
+       */
       parser->limits.max_match_rules_per_connection = 512;
       
       parser->limits.reply_timeout = 5 * 60 * 1000; /* 5 minutes */