From: Andrew MacLeod Date: Wed, 28 Jul 2021 17:14:22 +0000 (-0400) Subject: Change integral divide by zero to produce UNDEFINED. X-Git-Tag: basepoints/gcc-13~5677 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebbcdd7fae1f802763850e4afedfdfa09cf10e1a;p=thirdparty%2Fgcc.git Change integral divide by zero to produce UNDEFINED. Instead of VARYING, we can get better results by treating divide by zero as producing an undefined result. gcc/ * range-op.cc (operator_div::wi_fold): Return UNDEFINED for [0, 0] divisor. gcc/testsuite/ * gcc.dg/tree-ssa/pr61839_2.c: Adjust. --- diff --git a/gcc/range-op.cc b/gcc/range-op.cc index b1fb25c77f82..69228882930b 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -1785,13 +1785,6 @@ operator_div::wi_fold (irange &r, tree type, const wide_int &lh_lb, const wide_int &lh_ub, const wide_int &rh_lb, const wide_int &rh_ub) const { - // If we know we will divide by zero... - if (rh_lb == 0 && rh_ub == 0) - { - r.set_varying (type); - return; - } - const wide_int dividend_min = lh_lb; const wide_int dividend_max = lh_ub; const wide_int divisor_min = rh_lb; @@ -1818,7 +1811,7 @@ operator_div::wi_fold (irange &r, tree type, // If we're definitely dividing by zero, there's nothing to do. if (wi_zero_p (type, divisor_min, divisor_max)) { - r.set_varying (type); + r.set_undefined (); return; } diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr61839_2.c b/gcc/testsuite/gcc.dg/tree-ssa/pr61839_2.c index cfec54de991c..f1b8feb4e9d3 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/pr61839_2.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr61839_2.c @@ -45,9 +45,8 @@ int bar2 () return 0; } - /* Dont optimize 972195717 / 0 in function foo. */ -/* { dg-final { scan-tree-dump-times "972195717 / " 1 "evrp" } } */ +/* { dg-final { scan-tree-dump-times "972195717 / " 0 "evrp" } } */ /* Dont optimize 972195717 % 0 in function bar. */ /* { dg-final { scan-tree-dump-times "972195717 % " 1 "evrp" } } */ /* May optimize in function bar2, but EVRP doesn't perform this yet. */