From: Michael Jerris <mike@jerris.com>
Date: Thu, 15 May 2014 18:34:25 +0000 (+0000)
Subject: CID:1024250 Dereference before null check. CID:1024251 Dereference before null check... 
X-Git-Tag: v1.4.4~51
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebc0a99f1c3e8a6a31459b6d0a7ca02cd7e44e07;p=thirdparty%2Ffreeswitch.git

CID:1024250 Dereference before null check. CID:1024251 Dereference before null check, we don't need tto check these, as they are already used above in all cases
---

diff --git a/src/mod/endpoints/mod_sofia/rtp.c b/src/mod/endpoints/mod_sofia/rtp.c
index bbb78c88a2..3f704c5f10 100644
--- a/src/mod/endpoints/mod_sofia/rtp.c
+++ b/src/mod/endpoints/mod_sofia/rtp.c
@@ -529,22 +529,19 @@ static switch_status_t channel_receive_event(switch_core_session_t *session, swi
     }
 
     return SWITCH_STATUS_SUCCESS;
+
 fail:
-     if (tech_pvt) {
-        if (tech_pvt->read_codec.implementation) {
-			switch_core_codec_destroy(&tech_pvt->read_codec);
-		}
-		
-		if (tech_pvt->write_codec.implementation) {
-			switch_core_codec_destroy(&tech_pvt->write_codec);
-		}
-    }
-    
-    if (session) {
-        switch_core_session_destroy(&session);
-    }
-    return SWITCH_STATUS_FALSE;
+	if (tech_pvt->read_codec.implementation) {
+		switch_core_codec_destroy(&tech_pvt->read_codec);
+	}
+	
+	if (tech_pvt->write_codec.implementation) {
+		switch_core_codec_destroy(&tech_pvt->write_codec);
+	}
 
+	switch_core_session_destroy(&session);
+
+    return SWITCH_STATUS_FALSE;
 }
 
 static switch_status_t channel_receive_message(switch_core_session_t *session, switch_core_session_message_t *msg)