From: Pierre Chifflier <chifflier@wzdftpd.net>
Date: Thu, 5 Jun 2025 12:39:29 +0000 (+0200)
Subject: ldap: fix clippy warnings (unneded conversions)
X-Git-Tag: suricata-8.0.0-rc1~80
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebc1678c5c65a4f3fc35f6faeaa8fc5f464c7317;p=thirdparty%2Fsuricata.git

ldap: fix clippy warnings (unneded conversions)
---

diff --git a/rust/src/ldap/ldap.rs b/rust/src/ldap/ldap.rs
index e59e36cefd..65b0b066dd 100644
--- a/rust/src/ldap/ldap.rs
+++ b/rust/src/ldap/ldap.rs
@@ -234,7 +234,7 @@ impl LdapState {
                     }
                     let mut tx = tx.unwrap();
                     let tx_id = tx.id();
-                    let request = LdapMessage::from(msg);
+                    let request = msg;
                     // check if STARTTLS was requested
                     if let ProtocolOp::ExtendedRequest(request) = &request.protocol_op {
                         if request.request_name.0 == STARTTLS_OID {
@@ -299,7 +299,7 @@ impl LdapState {
             }
             match ldap_parse_msg(start) {
                 Ok((rem, msg)) => {
-                    let response = LdapMessage::from(msg);
+                    let response = msg;
                     // check if STARTTLS was requested
                     if self.request_tls {
                         if let ProtocolOp::ExtendedResponse(response) = &response.protocol_op {
@@ -395,7 +395,7 @@ impl LdapState {
                     return AppLayerResult::err();
                 }
                 let mut tx = tx.unwrap();
-                let request = LdapMessage::from(msg);
+                let request = msg;
                 tx.complete |= tx_is_complete(&request.protocol_op, Direction::ToServer);
                 tx.request = Some(request.to_static());
                 self.transactions.push_back(tx);
@@ -436,7 +436,7 @@ impl LdapState {
             }
             match ldap_parse_msg(start) {
                 Ok((rem, msg)) => {
-                    let response = LdapMessage::from(msg);
+                    let response = msg;
                     if let Some(tx) = self.find_request(response.message_id) {
                         tx.complete |= tx_is_complete(&response.protocol_op, Direction::ToClient);
                         let tx_id = tx.id();
@@ -535,7 +535,7 @@ fn tx_is_complete(op: &ProtocolOp, dir: Direction) -> bool {
 fn probe(input: &[u8], direction: Direction, rdir: *mut u8) -> AppProto {
     match ldap_parse_msg(input) {
         Ok((_, msg)) => {
-            let ldap_msg = LdapMessage::from(msg);
+            let ldap_msg = msg;
             if direction == Direction::ToServer && !ldap_is_request(&ldap_msg) {
                 unsafe {
                     *rdir = Direction::ToClient.into();