From: Jakub Karolczyk <jakub.karolczyk@signalwire.com>
Date: Fri, 1 Sep 2023 10:23:28 +0000 (+0100)
Subject: [core] Coverity 1325269 Dereference before null check
X-Git-Tag: v1.10.11^2~16^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebcb099a0191740832d4e0763e22bdcc3b634c37;p=thirdparty%2Ffreeswitch.git

[core] Coverity 1325269 Dereference before null check
---

diff --git a/src/switch_jitterbuffer.c b/src/switch_jitterbuffer.c
index 6f142aec6d..655fa022c2 100644
--- a/src/switch_jitterbuffer.c
+++ b/src/switch_jitterbuffer.c
@@ -1719,20 +1719,13 @@ SWITCH_DECLARE(switch_status_t) switch_jb_get_packet(switch_jb_t *jb, switch_rtp
 		}
 	}
 
-	if (node) {
-		status = SWITCH_STATUS_SUCCESS;
+	*packet = node->packet;
+	*len = node->len;
+	jb->last_len = *len;
+	packet->header.version = 2;
+	hide_node(node, SWITCH_TRUE);
 
-		*packet = node->packet;
-		*len = node->len;
-		jb->last_len = *len;
-		packet->header.version = 2;
-		hide_node(node, SWITCH_TRUE);
-
-		jb_debug(jb, 2, "GET packet ts:%u seq:%u %s\n", ntohl(packet->header.ts), ntohs(packet->header.seq), packet->header.m ? " <MARK>" : "");
-
-	} else {
-		status = SWITCH_STATUS_MORE_DATA;
-	}
+	jb_debug(jb, 2, "GET packet ts:%u seq:%u %s\n", ntohl(packet->header.ts), ntohs(packet->header.seq), packet->header.m ? " <MARK>" : "");
 
  end: