From: John Ferlan <jferlan@redhat.com>
Date: Wed, 1 Jul 2015 10:28:12 +0000 (-0400)
Subject: qemu: Resolve Coverity DEADCODE
X-Git-Tag: v1.2.17~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebd62ebaaa90a9a4d7fb05d85ec866b1ed3c2c3f;p=thirdparty%2Flibvirt.git

qemu: Resolve Coverity DEADCODE

Commit id 'f967e7a6' didn't place the closing parentheses quite right
causing DEADCODE errors since the rc setting/comparison was wrong.
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 391190dcdd..79338cf61d 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1586,7 +1586,7 @@ int qemuDomainAttachChrDevice(virQEMUDriverPtr driver,
     if (qemuAssignDeviceChrAlias(vmdef, chr, -1) < 0)
         goto cleanup;
 
-    if ((rc = qemuDomainAttachChrDeviceAssignAddr(priv, chr) < 0))
+    if ((rc = qemuDomainAttachChrDeviceAssignAddr(priv, chr)) < 0)
         goto cleanup;
     if (rc == 1)
         need_release = true;