From: Tom Hromatka Date: Tue, 27 Apr 2021 16:30:21 +0000 (+0000) Subject: api.c: Fix strncpy() truncation warning X-Git-Tag: v2.0~2^2~15 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebe4af441fdff2604e0df82c5669e688f7b4d109;p=thirdparty%2Flibcgroup.git api.c: Fix strncpy() truncation warning Fix the following strncpy() string truncation warning: In function ‘strncpy’, inlined from ‘cgroup_parse_rules_file’ at api.c:676:3: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin___strncpy_chk’ output may be truncated copying between 0 and 255 bytes from a string of length 4352 [-Wstringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Tom Hromatka --- diff --git a/src/api.c b/src/api.c index 68357e67..77c6838b 100644 --- a/src/api.c +++ b/src/api.c @@ -674,6 +674,7 @@ static int cgroup_parse_rules_file(char *filename, bool cache, uid_t muid, len_username = min(len_username, sizeof(user) - 1); memset(user, '\0', sizeof(user)); strncpy(user, key, len_username); + user[sizeof(user) - 1] = '\0'; /* * Next, check the user/group. If it's a % sign, then we