From: Ralph Boehme Date: Thu, 10 Oct 2024 17:25:30 +0000 (+0200) Subject: smbd: force sync rename with lease break X-Git-Tag: samba-4.20.7~19 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebf4b30d087b20c6f1e1547005ef9c1c452772f4;p=thirdparty%2Fsamba.git smbd: force sync rename with lease break BUG: https://bugzilla.samba.org/show_bug.cgi?id=15697 Signed-off-by: Ralph Boehme Reviewed-by: Stefan Metzmacher (cherry picked from commit bc2d87981967bc65155ba09eb5b3e3f913bec50e) --- diff --git a/selftest/knownfail.d/samba3.smb2.compound_async b/selftest/knownfail.d/samba3.smb2.compound_async index 20de45d5061..2d956ba45b0 100644 --- a/selftest/knownfail.d/samba3.smb2.compound_async +++ b/selftest/knownfail.d/samba3.smb2.compound_async @@ -1,4 +1 @@ -^samba3.smb2.compound_async.rename_non_compound_no_async\(fileserver\) -^samba3.smb2.compound_async.rename_same_srcdst_non_compound_no_async\(fileserver\) -^samba3.smb2.compound_async.rename_last\(fileserver\) ^samba3.smb2.compound_async.rename_middle\(fileserver\) diff --git a/source3/smbd/smb2_setinfo.c b/source3/smbd/smb2_setinfo.c index f26fce77a23..575aa26dfd8 100644 --- a/source3/smbd/smb2_setinfo.c +++ b/source3/smbd/smb2_setinfo.c @@ -120,7 +120,11 @@ NTSTATUS smbd_smb2_request_process_setinfo(struct smbd_smb2_request *req) } tevent_req_set_callback(subreq, smbd_smb2_request_setinfo_done, req); - return smbd_smb2_request_pending_queue(req, subreq, 500); + /* + * Windows never sends async interim responses if a rename triggers a + * lease break. See test smb2.lease.compound_rename_middle. + */ + return smbd_smb2_request_pending_queue(req, subreq, 0); } static void smbd_smb2_request_setinfo_done(struct tevent_req *subreq)