From: Ondřej Surý <ondrej@isc.org>
Date: Fri, 10 Apr 2026 11:19:55 +0000 (+0200)
Subject: Replace FIXME with rationale for not cleaning expired delegdb nodes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec024735dfa4d06f53047c633895bef74418b2fb;p=thirdparty%2Fbind9.git

Replace FIXME with rationale for not cleaning expired delegdb nodes

Expired delegation nodes are naturally replaced when the resolver
fetches fresh data, and any remaining stale nodes are reclaimed by
SIEVE eviction under memory pressure.
---

diff --git a/lib/dns/deleg.c b/lib/dns/deleg.c
index 151d7fe8ba9..92ee3f1a8f1 100644
--- a/lib/dns/deleg.c
+++ b/lib/dns/deleg.c
@@ -339,9 +339,11 @@ dns__deleg_lookup(dns_delegdb_t *delegdb, dns_qpread_t *qpr,
 	}
 
 	/*
-	 * FIXME: if we lookup something that has expired, we need
-	 * either the "deadnodes" (see qpcache) mechanism here - or call
-	 * something like isc_async_run(delete_me, node).
+	 * The expired node will be replaced when the resolver fetches
+	 * a fresh delegation, so there is no need to schedule explicit
+	 * cleanup here.  Stale nodes that are never replaced will
+	 * eventually be evicted by the SIEVE policy under memory
+	 * pressure.
 	 */
 	return ISC_R_NOTFOUND;
 }