From: Mathieu Dubois-Briand Date: Sat, 15 Nov 2025 07:41:31 +0000 (+0100) Subject: terminal: Show a warning when launched terminal quickly exits X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec62d469336c7d9939c4bf18e7f8bd191f26998d;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git terminal: Show a warning when launched terminal quickly exits Terminals quitting in less than one second are likely the result of a failure to execute the launched command: show a warning including the command that was launched, so the user can try to debug this. Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py index 4412bc14c1d..013d77581d5 100644 --- a/meta/lib/oe/terminal.py +++ b/meta/lib/oe/terminal.py @@ -240,6 +240,7 @@ def spawn(name, sh_cmd, title=None, env=None, d=None): import tempfile import time pidfile = tempfile.NamedTemporaryFile(delete = False).name + start_time = None try: sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd pipe = terminal(sh_cmd, title, env, d) @@ -249,6 +250,7 @@ def spawn(name, sh_cmd, title=None, env=None, d=None): if pipe.returncode != 0: raise ExecutionError(sh_cmd, pipe.returncode, output) + start_time = time.time() while os.stat(pidfile).st_size <= 0: time.sleep(0.01) continue @@ -262,7 +264,10 @@ def spawn(name, sh_cmd, title=None, env=None, d=None): os.kill(pid, 0) time.sleep(0.1) except OSError: - return + if start_time and (time.time() - start_time < 1): + bb.warn("Terminal \"%s\" started but stopped after only %.2fs while running \"%s\"" + % (name, time.time() - start_time, sh_cmd)) + return def check_tmux_version(desired): vernum = check_terminal_version("tmux")