From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Fri, 6 Oct 2023 01:02:42 +0000 (+1300)
Subject: s3:smbd: Remove unreachable code (CID 710840)
X-Git-Tag: talloc-2.4.2~883
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec687e7ca9178342a8ecf208de8ea143ffb3e2b1;p=thirdparty%2Fsamba.git

s3:smbd: Remove unreachable code (CID 710840)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/smbd/smb2_ioctl.c b/source3/smbd/smb2_ioctl.c
index 2ca53e33788..7d0f11df1ad 100644
--- a/source3/smbd/smb2_ioctl.c
+++ b/source3/smbd/smb2_ioctl.c
@@ -454,19 +454,14 @@ static struct tevent_req *smbd_smb2_ioctl_send(TALLOC_CTX *mem_ctx,
 	switch (in_ctl_code & IOCTL_DEV_TYPE_MASK) {
 	case FSCTL_DFS:
 		return smb2_ioctl_dfs(in_ctl_code, ev, req, state);
-		break;
 	case FSCTL_FILESYSTEM:
 		return smb2_ioctl_filesys(in_ctl_code, ev, req, state);
-		break;
 	case FSCTL_NAMED_PIPE:
 		return smb2_ioctl_named_pipe(in_ctl_code, ev, req, state);
-		break;
 	case FSCTL_NETWORK_FILESYSTEM:
 		return smb2_ioctl_network_fs(in_ctl_code, ev, req, state);
-		break;
 	case FSCTL_SMBTORTURE:
 		return smb2_ioctl_smbtorture(in_ctl_code, ev, req, state);
-		break;
 	default:
 		if (IS_IPC(smbreq->conn)) {
 			tevent_req_nterror(req, NT_STATUS_FS_DRIVER_REQUIRED);
@@ -475,11 +470,7 @@ static struct tevent_req *smbd_smb2_ioctl_send(TALLOC_CTX *mem_ctx,
 		}
 
 		return tevent_req_post(req, ev);
-		break;
 	}
-
-	tevent_req_nterror(req, NT_STATUS_INTERNAL_ERROR);
-	return tevent_req_post(req, ev);
 }
 
 static NTSTATUS smbd_smb2_ioctl_recv(struct tevent_req *req,