From: Alexander Bainbridge-Sedivy <alex.bainbridge@inkbridge.io>
Date: Wed, 13 May 2026 13:35:49 +0000 (-0400)
Subject: rlm_sigtran: fix tautological condition and inverted range check in SCCP global title... 
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec6ce98ab04aac2dbfe552b21ac85f78bdee20f9;p=thirdparty%2Ffreeradius-server.git

rlm_sigtran: fix tautological condition and inverted range check in SCCP global title validation
---

diff --git a/src/modules/rlm_sigtran/rlm_sigtran.c b/src/modules/rlm_sigtran/rlm_sigtran.c
index cc7a2364153..7fa5cbd43ad 100644
--- a/src/modules/rlm_sigtran/rlm_sigtran.c
+++ b/src/modules/rlm_sigtran/rlm_sigtran.c
@@ -254,13 +254,13 @@ static int sigtran_sccp_sockaddr_from_conf(TALLOC_CTX *ctx,
 
 		if (conf->gt.tt_is_set) {
 			if ((conf->gt.np_is_set && !conf->gt.es_is_set) ||
-			    (!conf->gt.np_is_set && conf->gt.np_is_set)) {
+			    (!conf->gt.np_is_set && conf->gt.es_is_set)) {
 				cf_log_err(cs, "Global title 'np' and 'es' must be "
 					      "specified together");
 				return -1;
 			}
 
-			if (conf->gt.np) {
+			if (conf->gt.np > 0x0f) {
 				cf_log_err(cs, "Global title 'np' must be between 0-15");
 				return -1;
 			}