From: James Jones <jejones3141@gmail.com>
Date: Wed, 13 Apr 2022 20:46:25 +0000 (-0500)
Subject: Make POSIXification in exec_pair_to_env() notice lower case first char (#4458)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec86f62b0da14ad927b534dda4dcd150586a2e58;p=thirdparty%2Ffreeradius-server.git

Make POSIXification in exec_pair_to_env() notice lower case first char (#4458)

The loop as written always incremented p after the test to deal with
leading digits, so it wouldn't notice a leading lower case letter.
---

diff --git a/src/lib/server/exec.c b/src/lib/server/exec.c
index 7e35562d10e..adac648e442 100644
--- a/src/lib/server/exec.c
+++ b/src/lib/server/exec.c
@@ -154,8 +154,8 @@ static int exec_pair_to_env(char **env_p, size_t env_len, fr_sbuff_t *env_sbuff,
 		 *	for the first char.
 		 */
 		p = fr_sbuff_current(&env_m[i]);
-		if (isdigit((int)*p)) *p = '_';
-		while (p++ < fr_sbuff_current(&sbuff)) {
+		if (isdigit((int)*p)) *p++ = '_';
+		for (; p < fr_sbuff_current(&sbuff); p++) {
 			if (isalpha((int)*p)) *p = toupper(*p);
 			else if (*p == '-') *p = '_';
 			else if (isdigit((int)*p)) continue;