From: NeilBrown <neilb@suse.de>
Date: Thu, 27 Sep 2012 06:57:08 +0000 (+1000)
Subject: Manage: zero metadata before adding to 'external' array.
X-Git-Tag: mdadm-3.2.6~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec894f5eb1bc068297bb7f988dca2c3dcf42d644;p=thirdparty%2Fmdadm.git

Manage: zero metadata before adding to 'external' array.

'external' arrays don't support --re-add yet so old metadata is no
value, and 'ddf' gets confusing in mdmon if old metadata is found.
So for now, zero out any old metadata found before adding a spare to
an externally-managed array.

Reported-by: Albert Pauw <albert.pauw@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/Manage.c b/Manage.c
index 95aa2704..ab4bb75e 100644
--- a/Manage.c
+++ b/Manage.c
@@ -1003,6 +1003,7 @@ int Manage_subdevs(char *devname, int fd,
 					goto abort;
 				}
 
+				Kill(dv->devname, NULL, 0, -1, 0);
 				dfd = dev_open(dv->devname, O_RDWR | O_EXCL|O_DIRECT);
 				if (mdmon_running(tst->container_dev))
 					tst->update_tail = &tst->updates;