From: Peiwei Hu <jlu.hpw@foxmail.com>
Date: Wed, 15 Dec 2021 09:46:04 +0000 (+0800)
Subject: get_ecdsa_sig_rs_bytes: free value of d2i_ECDSA_SIG() before return
X-Git-Tag: openssl-3.2.0-alpha1~3185
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ec9135a62320c861ab17f7179ebe470686360c64;p=thirdparty%2Fopenssl.git

get_ecdsa_sig_rs_bytes: free value of d2i_ECDSA_SIG() before return

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17280)
---

diff --git a/test/acvp_test.c b/test/acvp_test.c
index d8425f0d207..bbc77d0ae61 100644
--- a/test/acvp_test.c
+++ b/test/acvp_test.c
@@ -218,7 +218,7 @@ static int get_ecdsa_sig_rs_bytes(const unsigned char *sig, size_t sig_len,
     r1 = ECDSA_SIG_get0_r(sign);
     s1 = ECDSA_SIG_get0_s(sign);
     if (r1 == NULL || s1 == NULL)
-        return 0;
+        goto err;
 
     r1_len = BN_num_bytes(r1);
     s1_len = BN_num_bytes(s1);
@@ -560,7 +560,7 @@ static int get_dsa_sig_rs_bytes(const unsigned char *sig, size_t sig_len,
         return 0;
     DSA_SIG_get0(sign, &r1, &s1);
     if (r1 == NULL || s1 == NULL)
-        return 0;
+        goto err;
 
     r1_len = BN_num_bytes(r1);
     s1_len = BN_num_bytes(s1);