From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Sat, 20 Apr 2024 07:55:32 +0000 (+0200)
Subject: fixup! rrl: improve error messages
X-Git-Tag: v6.0.9~1^2~56
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eca0526999b96f03d7c3446264aa8f42b4e9ece2;p=thirdparty%2Fknot-resolver.git

fixup! rrl: improve error messages
---

diff --git a/daemon/rrl/api.c b/daemon/rrl/api.c
index d9f133681..63ec5e60f 100644
--- a/daemon/rrl/api.c
+++ b/daemon/rrl/api.c
@@ -34,7 +34,8 @@ void kr_rrl_init(const char *mmap_file, size_t capacity, uint32_t instant_limit,
 {
 	int fd = the_rrl_fd = open(mmap_file, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR);
 	if (fd == -1) {
-		kr_log_crit(SYSTEM, "Cannot open file %s containing shared rate-limiting data.", mmap_file);
+		kr_log_crit(SYSTEM, "Cannot open file %s containing shared rate-limiting data: %s\n",
+				mmap_file, strerror(errno));
 		abort();
 	}
 
@@ -54,9 +55,9 @@ void kr_rrl_init(const char *mmap_file, size_t capacity, uint32_t instant_limit,
 		.l_len    = 0 };
 	if (fcntl(fd, F_SETLK, &fl) != -1) {
 		kr_log_info(SYSTEM, "Initializing rate-limiting...\n");
-		ftruncate(fd, 0);
-		if (ftruncate(fd, size) == -1) {  // get all zeroed
-			kr_log_crit(SYSTEM, "Cannot increase size of file %s containing shared rate-limiting data.", mmap_file);
+		if (ftruncate(fd, 0) == -1 || ftruncate(fd, size) == -1) {  // get all zeroed
+			kr_log_crit(SYSTEM, "Cannot change size of file %s containing shared rate-limiting data: %s\n",
+					mmap_file, strerror(errno));
 			abort();
 		}
 		the_rrl = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);