From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 19 Oct 2022 12:14:33 +0000 (+0200)
Subject: qemuAppendDomainMemoryMachineParams: Refactor formatting of 'dump-guest-core'
X-Git-Tag: v8.10.0-rc1~253
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ecb8c93196a5c58133eb308acd953d3c7f3d08ba;p=thirdparty%2Flibvirt.git

qemuAppendDomainMemoryMachineParams: Refactor formatting of 'dump-guest-core'

Use virTristateSwitchFromBool to fill in the default if user didn't
request it explicitly.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 57164b7ae6..1f285e5024 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -6625,15 +6625,13 @@ qemuAppendDomainMemoryMachineParams(virBuffer *buf,
                                     const virDomainDef *def,
                                     virQEMUCaps *qemuCaps)
 {
+    virTristateSwitch dump = def->mem.dump_core;
     size_t i;
 
-    if (def->mem.dump_core) {
-        virBufferAsprintf(buf, ",dump-guest-core=%s",
-                          virTristateSwitchTypeToString(def->mem.dump_core));
-    } else {
-        virBufferAsprintf(buf, ",dump-guest-core=%s",
-                          cfg->dumpGuestCore ? "on" : "off");
-    }
+    if (dump == VIR_TRISTATE_SWITCH_ABSENT)
+        dump = virTristateSwitchFromBool(cfg->dumpGuestCore);
+
+    virBufferAsprintf(buf, ",dump-guest-core=%s", virTristateSwitchTypeToString(dump));
 
     if (def->mem.nosharepages)
         virBufferAddLit(buf, ",mem-merge=off");