From: Matthew Jordan Date: Sat, 28 Sep 2013 22:21:37 +0000 (+0000) Subject: res_rtp_asterisk: Correct erroneous lost packet information in RTCP reports X-Git-Tag: 11.7.0-rc1~46 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ecdd1e76eb9fd8f3ebff291b08cc81f9986137c2;p=thirdparty%2Fasterisk.git res_rtp_asterisk: Correct erroneous lost packet information in RTCP reports RTCP's calculation of the number of lost packets in an RTP stream is based on that stream's sequence number count, the number of received packets, and how many packets we expect to receive. When the SSRC for an RTP stream changes, there can - and almost always will be - a large jump in the next packet's timestamp and sequence number. If we don't reset the number of received packets, sequence number count, and other metrics used by RTCP, the next RR/SR report will use the previous SSRC's values to calculate the lost packet count for the new SSRC - resulting in a very large number of lost packets. This patch modifies res_rtp_asterisk such that, if it detects a SSRC change, it will reset the various values used by the RTCP calculations. From the perspective of RTCP, this appears as a new media stream - which is what it is. Review: https://reviewboard.asterisk.org/r/2886/ (closes issue AST-1174) Reported by: Thomas Arimont ........ Merged revisions 400089 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@400093 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c index ed10f35df6..9b1716a29e 100644 --- a/res/res_rtp_asterisk.c +++ b/res/res_rtp_asterisk.c @@ -3654,6 +3654,12 @@ static struct ast_frame *ast_rtp_read(struct ast_rtp_instance *instance, int rtc f = ast_frisolate(&srcupdate); AST_LIST_INSERT_TAIL(&frames, f, frame_list); + rtp->seedrxseqno = 0; + rtp->rxcount = 0; + rtp->cycles = 0; + rtp->lastrxseqno = 0; + rtp->rtcp->expected_prior = 0; + rtp->rtcp->received_prior = 0; rtp->last_seqno = 0; rtp->last_end_timestamp = 0; }