From: Matthijs Mekking <matthijs@isc.org>
Date: Wed, 12 Mar 2025 15:39:36 +0000 (+0100)
Subject: Fix CID 544147
X-Git-Tag: v9.21.7~62^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ecef45bf18bfe038d054b1644c0718ac599188bb;p=thirdparty%2Fbind9.git

Fix CID 544147

Assigning value "NULL" to "newstr", but that stored value is overwritten
before it can be used.

Setting "newstr" to NULL does not have any effect, so the line can
safely be removed.
---

diff --git a/bin/named/controlconf.c b/bin/named/controlconf.c
index 5f792d76c20..d01a91a8b15 100644
--- a/bin/named/controlconf.c
+++ b/bin/named/controlconf.c
@@ -736,7 +736,6 @@ controlkeylist_fromcfg(const cfg_obj_t *keylist, isc_mem_t *mctx,
 		key->secret.length = 0;
 		ISC_LINK_INIT(key, link);
 		ISC_LIST_APPEND(*keyids, key, link);
-		newstr = NULL;
 	}
 }