From: Dmitry Baryshkov Date: Sat, 7 Feb 2026 10:28:52 +0000 (+0200) Subject: power: sequencing: qcom-wcn: fix error path for VDDIO handling X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ecfcae7885f105b29898ff71d3cb70abd56ef96e;p=thirdparty%2Fkernel%2Flinux.git power: sequencing: qcom-wcn: fix error path for VDDIO handling In case getting VDDIO regulator returned an error, WCN power sequencing driver passes ret to dev_err_probe() as the error code, however it is known that ret is 0 at this point. Pass PTR_ERR(ctx->vddio) instead. Fixes: 0eb85f468ef5 ("power: sequencing: qcom-wcn: add support for WCN39xx") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/aYXvQxKqmjP_sdCd@stanley.mountain/ Signed-off-by: Dmitry Baryshkov Link: https://patch.msgid.link/20260207-fix-wcn39xx-v1-1-df0606108ce2@oss.qualcomm.com Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/sequencing/pwrseq-qcom-wcn.c index 46a484b0b5a11..b55b4317e21b6 100644 --- a/drivers/power/sequencing/pwrseq-qcom-wcn.c +++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c @@ -489,7 +489,7 @@ static int pwrseq_qcom_wcn_probe(struct platform_device *pdev) if (ctx->pdata->has_vddio) { ctx->vddio = devm_regulator_get(dev, "vddio"); if (IS_ERR(ctx->vddio)) - return dev_err_probe(dev, ret, "Failed to get VDDIO\n"); + return dev_err_probe(dev, PTR_ERR(ctx->vddio), "Failed to get VDDIO\n"); } ctx->bt_gpio = devm_gpiod_get_optional(dev, "bt-enable", GPIOD_OUT_LOW);