From: gerv%gerv.net <>
Date: Tue, 4 Jan 2005 04:54:57 +0000 (+0000)
Subject: Bug 272620: avoid XSS problem with internal error messages. Patch by gerv; r=justdave... 
X-Git-Tag: bugzilla-2.19.2~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed09207ecef601b38bff1392ef5e1726e8fc44c5;p=thirdparty%2Fbugzilla.git

Bug 272620: avoid XSS problem with internal error messages. Patch by gerv; r=justdave; a=justdave.
---

diff --git a/Bugzilla/Error.pm b/Bugzilla/Error.pm
index 00a2675eb0..96017f368f 100644
--- a/Bugzilla/Error.pm
+++ b/Bugzilla/Error.pm
@@ -118,7 +118,10 @@ sub ThrowTemplateError {
             time this message appeared.
           </p>
           <script type="text/javascript"> <!--
-            document.write("<p>URL: " + document.location + "</p>");
+          document.write("<p>URL: " + 
+                          document.location.href.replace(/&/g,"&amp;")
+                                                .replace(/</g,"&lt;")
+                                                .replace(/>/g,"&gt;") + "</p>");
           // -->
           </script>
           <p>Template->process() failed twice.<br>
diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl
index 42172d900a..5026d8314e 100644
--- a/template/en/default/global/code-error.html.tmpl
+++ b/template/en/default/global/code-error.html.tmpl
@@ -256,7 +256,10 @@
     the time this message appeared.
   </p>
   <script type="text/javascript"> <!--
-    document.write("<p>URL: " + document.location + "</p>");
+    document.write("<p>URL: " + 
+                    document.location.href.replace(/&/g,"&amp;")
+                                          .replace(/</g,"&lt;")
+                                          .replace(/>/g,"&gt;") + "</p>");
   // -->
   </script>
 </tt>