From: Marcin Siodelski <marcin@isc.org>
Date: Mon, 20 Sep 2021 19:35:12 +0000 (+0200)
Subject: [#1959] Prettier ha service unit test
X-Git-Tag: Kea-2.0.0~75
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed10262b3fabfff16a67457bd8c3fd69e22726c4;p=thirdparty%2Fkea.git

[#1959] Prettier ha service unit test

Per review comments.
---

diff --git a/src/hooks/dhcp/high_availability/tests/ha_service_unittest.cc b/src/hooks/dhcp/high_availability/tests/ha_service_unittest.cc
index 03ee3a162b..c8fddcfa7d 100644
--- a/src/hooks/dhcp/high_availability/tests/ha_service_unittest.cc
+++ b/src/hooks/dhcp/high_availability/tests/ha_service_unittest.cc
@@ -2520,7 +2520,8 @@ TEST_F(HAServiceTest, processHeartbeat) {
     TestHAService service(io_service_,  network_state_, config_storage);
     service.query_filter_.serveDefaultScopes();
 
-    for (auto i = 0; i < 6; ++i) {
+    int unsent_updates = 6;
+    for (auto i = 0; i < unsent_updates; ++i) {
         service.communication_state_->increaseUnsentUpdateCount();
     }
 
@@ -2574,7 +2575,7 @@ TEST_F(HAServiceTest, processHeartbeat) {
     ConstElementPtr unsent_update_count = args->get("unsent-update-count");
     ASSERT_TRUE(unsent_update_count);
     EXPECT_EQ(Element::integer, unsent_update_count->getType());
-    EXPECT_EQ(6, static_cast<uint64_t>(unsent_update_count->intValue()));
+    EXPECT_EQ(unsent_updates, static_cast<uint64_t>(unsent_update_count->intValue()));
 }
 
 // This test verifies that the correct value of the heartbeat-delay is used.