From: Richard Guenther Date: Fri, 10 Jul 2009 15:55:04 +0000 (+0000) Subject: backport: re PR c++/36089 (Funny rejects valid with constant integral expression) X-Git-Tag: releases/gcc-4.3.4~83 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed11d1bc324f1ea8a294e4de0433fe374a1af6f6;p=thirdparty%2Fgcc.git backport: re PR c++/36089 (Funny rejects valid with constant integral expression) 2009-07-10 Richard Guenther Backport from mainline 2008-11-17 Jakub Jelinek PR c++/36089 * init.c (constant_value_1): Handle TREE_LIST init. PR c++/37561 PR c++/36089 * g++.dg/template/init8.C: New test. From-SVN: r149484 --- diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index a247aba286d7..7cd01de33016 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,11 @@ +2009-07-10 Richard Guenther + + Backport from mainline + 2008-11-17 Jakub Jelinek + + PR c++/36089 + * init.c (constant_value_1): Handle TREE_LIST init. + 2009-06-25 Richard Guenther Backport from mainline diff --git a/gcc/cp/init.c b/gcc/cp/init.c index 3e6db2471375..4b115dd97f0d 100644 --- a/gcc/cp/init.c +++ b/gcc/cp/init.c @@ -1636,6 +1636,15 @@ constant_value_1 (tree decl, bool integral_p) } if (init == error_mark_node) return decl; + /* Initializers in templates are generally expanded during + instantiation, so before that for const int i(2) + INIT is a TREE_LIST with the actual initializer as + TREE_VALUE. */ + if (processing_template_decl + && init + && TREE_CODE (init) == TREE_LIST + && TREE_CHAIN (init) == NULL_TREE) + init = TREE_VALUE (init); if (!init || !TREE_TYPE (init) || (integral_p diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 98848545a8de..250ae1f209e6 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,12 @@ +2009-07-10 Richard Guenther + + Backport from mainline + 2008-11-17 Jakub Jelinek + + PR c++/37561 + PR c++/36089 + * g++.dg/template/init8.C: New test. + 2009-07-07 Richard Guenther PR middle-end/40328 diff --git a/gcc/testsuite/g++.dg/template/init8.C b/gcc/testsuite/g++.dg/template/init8.C new file mode 100644 index 000000000000..1bcda1253d1b --- /dev/null +++ b/gcc/testsuite/g++.dg/template/init8.C @@ -0,0 +1,68 @@ +// PR c++/36089 +// { dg-do run } + +extern "C" void abort (); + +int f () +{ + const int c(2); + int d[c] = { 0, 0 }; + return d[0] + sizeof d; +} + +struct A +{ + static int f () + { + const int c(2); + int d[c] = { 0, 0 }; + return d[0] + sizeof d; + } +}; + +template struct B +{ + static int f () + { + const int c = 2; + int d[c] = { 0, 0 }; + return d[0] + sizeof d; + } +}; + +template struct C +{ + static int f () + { + const int c(2); + int d[c] = { 0, 0 }; + return d[0] + sizeof d; + } +}; + +template struct D +{ + static int f () + { + const int e(2); + const int c(e); + int d[c] = { 0, 0 }; + return d[0] + sizeof d; + } +}; + +int +main (void) +{ + int v = f (); + if (v != 2 * sizeof (int)) + abort (); + if (v != A::f ()) + abort (); + if (v != B<6>::f ()) + abort (); + if (v != C<0>::f ()) + abort (); + if (v != D<1>::f ()) + abort (); +}