From: Christopher Faulet <cfaulet@haproxy.com>
Date: Thu, 29 Nov 2018 21:53:30 +0000 (+0100)
Subject: BUG/MINOR: http: Use out buffer instead of trash to display error snapshot
X-Git-Tag: v1.9-dev9~93
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed26fb8ac82708f6fb1c2ea7ee1c084d5f7cc647;p=thirdparty%2Fhaproxy.git

BUG/MINOR: http: Use out buffer instead of trash to display error snapshot

the function http_show_error_snapshot() must not use the trash buffer to append
the HTTP error description. Instead, it must use the <out> buffer, its first
argument. Note that concretely, this function always succeeds because <out> is
always the trash buffer.
---

diff --git a/src/proto_http.c b/src/proto_http.c
index 7c658d92b2..43c1fcd456 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -7421,7 +7421,7 @@ int stats_check_uri(struct stream_interface *si, struct http_txn *txn, struct pr
  */
 void http_show_error_snapshot(struct buffer *out, const struct error_snapshot *es)
 {
-	chunk_appendf(&trash,
+	chunk_appendf(out,
 	              "  stream #%d, stream flags 0x%08x, tx flags 0x%08x\n"
 	              "  HTTP msg state %s(%d), msg flags 0x%08x\n"
 	              "  HTTP chunk len %lld bytes, HTTP body len %lld bytes, channel flags 0x%08x :\n",