From: Markus Elfring Date: Thu, 3 Oct 2024 09:01:30 +0000 (+0200) Subject: PM / devfreq: event: Call of_node_put() only once in devfreq_event_get_edev_by_phandle() X-Git-Tag: v6.14-rc1~148^2~1^2^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed33fbb5d5536db77bd168e8fefde8dbc077cfd7;p=thirdparty%2Fkernel%2Fstable.git PM / devfreq: event: Call of_node_put() only once in devfreq_event_get_edev_by_phandle() An of_node_put(node) call was immediately used after a null pointer check for the local variable “edev” at the end of this function implementation. Thus call such a function only once instead directly before the check. This issue was transformed by using the Coccinelle software. Link: https://lore.kernel.org/lkml/0f103384-376c-41f0-a35c-8ad98327d6cb@web.de/ Signed-off-by: Markus Elfring Signed-off-by: Chanwoo Choi --- diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c index 3ebac2496679b..70219099c6040 100644 --- a/drivers/devfreq/devfreq-event.c +++ b/drivers/devfreq/devfreq-event.c @@ -244,13 +244,9 @@ struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(struct device *dev, edev = NULL; out: mutex_unlock(&devfreq_event_list_lock); - - if (!edev) { - of_node_put(node); - return ERR_PTR(-ENODEV); - } - of_node_put(node); + if (!edev) + return ERR_PTR(-ENODEV); return edev; }