From: Volker Lendecke <vl@samba.org>
Date: Mon, 16 Dec 2019 15:47:38 +0000 (+0100)
Subject: smbd: Avoid a "? True : False"
X-Git-Tag: ldb-2.1.0~134
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed3ee452549f5c25800dd7da1c6dc30a826fe28f;p=thirdparty%2Fsamba.git

smbd: Avoid a "? True : False"

VALID_STAT() already is a boolean expression

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
---

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index a999f86dd44..57e68cab41d 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -4197,7 +4197,7 @@ static NTSTATUS open_directory(connection_struct *conn,
 			       files_struct **result)
 {
 	files_struct *fsp = NULL;
-	bool dir_existed = VALID_STAT(smb_dname->st) ? True : False;
+	bool dir_existed = VALID_STAT(smb_dname->st);
 	struct share_mode_lock *lck = NULL;
 	NTSTATUS status;
 	struct timespec mtimespec;