From: Dan Williams <dan.j.williams@intel.com>
Date: Tue, 15 Sep 2009 18:35:28 +0000 (-0700)
Subject: Examine: don't count containers as spares
X-Git-Tag: mdadm-3.0.1~2^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed57a7e8ba06237dc6f4a8f581d12353158ce798;p=thirdparty%2Fmdadm.git

Examine: don't count containers as spares

mdadm -Ebs will include containers in the scanned device list.
Examine() falsely thinks they are spares when MD_DISK_SYNC is not set.
This could be fixed by forcing all formats to set this flag for
container devices, but this flag is currently used by imsm to identify
free-floating spares.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

diff --git a/Examine.c b/Examine.c
index d4904bc9..7fbd4ae2 100644
--- a/Examine.c
+++ b/Examine.c
@@ -118,7 +118,8 @@ int Examine(mddev_dev_t devlist, int brief, int export, int scan,
 				st->ss->getinfo_super(st, &ap->info);
 			} else
 				st->ss->getinfo_super(st, &ap->info);
-			if (!(ap->info.disk.state & (1<<MD_DISK_SYNC)))
+			if (!st->loaded_container &&
+			    !(ap->info.disk.state & (1<<MD_DISK_SYNC)))
 				ap->spares++;
 			d = dl_strdup(devlist->devname);
 			dl_add(ap->devs, d);