From: Michael Brown <mcb30@ipxe.org>
Date: Tue, 27 Mar 2012 13:58:45 +0000 (+0100)
Subject: [crypto] Add an explicit "RSA signature incorrect" error message
X-Git-Tag: v1.20.1~1875
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed64732b73d604e5209b95d31f2b855b1a4d11f4;p=thirdparty%2Fipxe.git

[crypto] Add an explicit "RSA signature incorrect" error message

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/crypto/rsa.c b/src/crypto/rsa.c
index 62f52c954..be2696ba8 100644
--- a/src/crypto/rsa.c
+++ b/src/crypto/rsa.c
@@ -39,6 +39,12 @@ FILE_LICENCE ( GPL2_OR_LATER );
  * RSA is documented in RFC 3447.
  */
 
+/* Disambiguate the various error causes */
+#define EACCES_VERIFY \
+	__einfo_error ( EINFO_EACCES_VERIFY )
+#define EINFO_EACCES_VERIFY \
+	__einfo_uniqify ( EINFO_EACCES, 0x01, "RSA signature incorrect" )
+
 /** "rsaEncryption" object identifier */
 static uint8_t oid_rsa_encryption[] = { ASN1_OID_RSAENCRYPTION };
 
@@ -610,7 +616,7 @@ static int rsa_verify ( void *ctx, struct digest_algorithm *digest,
 	if ( memcmp ( actual, expected, context->max_len ) != 0 ) {
 		DBGC ( context, "RSA %p signature verification failed\n",
 		       context );
-		return -EACCES;
+		return -EACCES_VERIFY;
 	}
 
 	DBGC ( context, "RSA %p signature verified successfully\n", context );