From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 26 Nov 2024 08:10:10 +0000 (+0100)
Subject: qemuBlockReopenAccess: Don't require backing chain terminator for non-chained images
X-Git-Tag: v10.10.0-rc2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed656f4c8fdd4e156127c4c2bf40d14f50dcc6a0;p=thirdparty%2Flibvirt.git

qemuBlockReopenAccess: Don't require backing chain terminator for non-chained images

Add an exception for image formats not supporting backing images so that
they can be reopened RW/RO without the need for adding a terminating
virStorageSource as they simply can't have a backing image.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
---

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index a7c8be8d8b..af317a1f1f 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -3182,7 +3182,7 @@ qemuBlockReopenAccess(virDomainObj *vm,
 
     /* If we are lacking the object here, qemu might have opened an image with
      * a node name unknown to us */
-    if (!src->backingStore) {
+    if (src->format >= VIR_STORAGE_FILE_BACKING && !src->backingStore) {
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                        _("can't reopen image with unknown presence of backing store"));
         return -1;