From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 6 Nov 2020 20:54:21 +0000 (-0500)
Subject: no need to print trailing junk at the end of a packet
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed8a7b40cc8d16d41810c9bc5a5133d4e35ab8ad;p=thirdparty%2Ffreeradius-server.git

no need to print trailing junk at the end of a packet
---

diff --git a/src/protocols/dhcpv4/decode.c b/src/protocols/dhcpv4/decode.c
index 2b2c534c887..1bc83c55cbe 100644
--- a/src/protocols/dhcpv4/decode.c
+++ b/src/protocols/dhcpv4/decode.c
@@ -496,16 +496,6 @@ ssize_t fr_dhcpv4_decode_option(TALLOC_CTX *ctx, fr_cursor_t *cursor,
 	 */
 	if (p[0] == 0) return 1;		/* 0x00 - Padding option */
 	if (p[0] == 255) {			/* 0xff - End of options signifier */
-#ifndef NDEBUG
-		size_t i;
-
-		for (i = 1; i < data_len; i++) {
-			if (p[i] != 0) {
-				FR_PROTO_HEX_DUMP(p + i, data_len - i, "ignoring trailing junk at end of packet");
-				break;
-			}
-		}
-#endif
 		return data_len;
 	}