From: Tobias Brunner <tobias@strongswan.org>
Date: Thu, 13 Jul 2017 09:54:50 +0000 (+0200)
Subject: error-notify: Don't stop sending notifies after removing a disconnected listener
X-Git-Tag: 5.6.0dr4~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed926a73dfa2cd5467b0a55f10ca3a52dcb53d54;p=thirdparty%2Fstrongswan.git

error-notify: Don't stop sending notifies after removing a disconnected listener

This prevented new listeners from receiving notifies if they joined
after another listener disconnected previously, and if they themselves
disconnected their old connection would prevent them again from getting
notifies.
---

diff --git a/src/libcharon/plugins/error_notify/error_notify_socket.c b/src/libcharon/plugins/error_notify/error_notify_socket.c
index 959c4c67d1..6b9622ae31 100644
--- a/src/libcharon/plugins/error_notify/error_notify_socket.c
+++ b/src/libcharon/plugins/error_notify/error_notify_socket.c
@@ -94,7 +94,6 @@ METHOD(error_notify_socket_t, notify, void,
 					DBG1(DBG_CFG, "sending notify failed: %s", strerror(errno));
 					break;
 			}
-			break;
 		}
 	}
 	enumerator->destroy(enumerator);
@@ -146,7 +145,7 @@ error_notify_socket_t *error_notify_socket_create()
 	this->service = lib->streams->create_service(lib->streams, uri, 10);
 	if (!this->service)
 	{
-		DBG1(DBG_CFG, "creating duplicheck socket failed");
+		DBG1(DBG_CFG, "creating error-notify socket failed");
 		destroy(this);
 		return NULL;
 	}