From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 7 May 2025 15:00:28 +0000 (+0200)
Subject: dnsdist: Be a bit more patient in the Backend Discovery test
X-Git-Tag: dnsdist-2.0.0-alpha2~22^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ed97954d5c073ef228d6cbb076a27bfafc5ad1f8;p=thirdparty%2Fpdns.git

dnsdist: Be a bit more patient in the Backend Discovery test
---

diff --git a/regression-tests.dnsdist/test_BackendDiscovery.py b/regression-tests.dnsdist/test_BackendDiscovery.py
index 49dd50d26e..8ac54b0faa 100644
--- a/regression-tests.dnsdist/test_BackendDiscovery.py
+++ b/regression-tests.dnsdist/test_BackendDiscovery.py
@@ -417,6 +417,7 @@ class TestBackendDiscoveryByHostname(DNSDistTest):
     _config_template = """
     setKey("%s")
     controlSocket("127.0.0.1:%d")
+    setVerboseHealthChecks(true)
 
     function resolveCB(hostname, ips)
       print('Got response for '..hostname)
@@ -428,6 +429,8 @@ class TestBackendDiscoveryByHostname(DNSDistTest):
 
     getAddressInfo('dns.quad9.net.', resolveCB)
     """
+    _verboseMode = True
+
     def checkBackends(self):
         output = self.sendConsoleCommand('showServers()')
         print(output)
@@ -450,7 +453,8 @@ class TestBackendDiscoveryByHostname(DNSDistTest):
             return False
 
         for backend in backends:
-            self.assertEqual(backends[backend], 'up')
+            if backends[backend] != 'up':
+                return False
 
         return True
 
@@ -461,5 +465,10 @@ class TestBackendDiscoveryByHostname(DNSDistTest):
         # enough time for resolution to happen
         time.sleep(4)
         if not self.checkBackends():
-            time.sleep(4)
-            self.assertTrue(self.checkBackends())
+            valid = False
+            for _ in range(8):
+                time.sleep(0.5)
+                if self.checkBackends():
+                    valid = True
+                    break
+            self.assertTrue(valid)