From: Joe Orton <jorton@apache.org>
Date: Tue, 14 Jul 2020 16:25:43 +0000 (+0000)
Subject: * modules/generators/mod_cgid.c (get_cgi_pid): Fix test for pid=0.
X-Git-Tag: 2.5.0-alpha2-ci-test-only~1265
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=edb644302a32a6191b37ea55812bc3e6a9d2b8cc;p=thirdparty%2Fapache%2Fhttpd.git

* modules/generators/mod_cgid.c (get_cgi_pid): Fix test for pid=0.
  (cgid_handler): Remove duplicated test for pid=0 here added in
  r1879119.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1879860 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/generators/mod_cgid.c b/modules/generators/mod_cgid.c
index 699d7059f9d..38038110550 100644
--- a/modules/generators/mod_cgid.c
+++ b/modules/generators/mod_cgid.c
@@ -1517,7 +1517,9 @@ static apr_status_t get_cgi_pid(request_rec *r,  cgid_server_conf *conf, pid_t *
         return stat;
     }
 
-    if (pid == 0) {
+    /* Don't accept zero as a pid here, calling kill(0, SIGTERM) etc
+     * later is unpleasant. */
+    if (*pid == 0) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01261)
                       "daemon couldn't find CGI process for connection %lu",
                       r->connection->id);
@@ -1650,9 +1652,7 @@ static int cgid_handler(request_rec *r)
     info->r = r;
     rv = get_cgi_pid(r, conf, &(info->pid));
 
-    /* Don't accept zero as a pid here, calling kill(0, SIGTERM) etc
-     * later is unpleasant. */
-    if (rv == APR_SUCCESS && info->pid) {
+    if (rv == APR_SUCCESS) {
         apr_pool_cleanup_register(r->pool, info,
                                   cleanup_script, apr_pool_cleanup_null);
     }