From: Johan Hovold Date: Thu, 12 Mar 2026 15:18:16 +0000 (+0100) Subject: spi: fix misleading controller registration kernel-doc X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=edc463d72d697ff22da8ba96c0fcb25f3586d9a2;p=thirdparty%2Flinux.git spi: fix misleading controller registration kernel-doc The controller reference count is not decremented on registration failures (and has not been for a very long time) contrary to what the outdated kernel-doc says. Drop the entire sentence about return values which are now documented in the Return section. Fixes: b885244eb262 ("[PATCH] spi: add spi_driver to SPI framework") Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260312151817.32100-5-johan@kernel.org Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index bfc42b75549a2..34aca18a96d8a 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3388,8 +3388,8 @@ static int spi_controller_id_alloc(struct spi_controller *ctlr, int start, int e * device identification, boards need configuration tables telling which * chip is at which address. * - * This must be called from context that can sleep. It returns zero on - * success, else a negative error code (dropping the controller's refcount). + * This must be called from context that can sleep. + * * After a successful return, the caller is responsible for calling * spi_unregister_controller(). *