From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 8 Dec 2022 10:18:34 +0000 (+0100)
Subject: virStorageBackendISCSISetAuth: Use g_strndup to '\0' terminate data
X-Git-Tag: v9.1.0-rc1~133
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=edd644e7a8a710020ea1c97c19448d91e07126b2;p=thirdparty%2Flibvirt.git

virStorageBackendISCSISetAuth: Use g_strndup to '\0' terminate data

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c
index e4fa49d05f..01900f6809 100644
--- a/src/storage/storage_backend_iscsi.c
+++ b/src/storage/storage_backend_iscsi.c
@@ -283,10 +283,8 @@ virStorageBackendISCSISetAuth(const char *portal,
                                  &secret_value, &secret_size) < 0)
         return -1;
 
-    secret_str = g_new0(char, secret_size + 1);
-    memcpy(secret_str, secret_value, secret_size);
+    secret_str = g_strndup((char *) secret_value, secret_size);
     virSecureErase(secret_value, secret_size);
-    secret_str[secret_size] = '\0';
 
     if (virISCSINodeUpdate(portal,
                            source->devices[0].path,