From: Daniel P. Berrange <berrange@redhat.com>
Date: Thu, 8 Jan 2015 14:55:39 +0000 (+0000)
Subject: parallels: don't override error message when XML parsing fails
X-Git-Tag: v1.2.12-rc1~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee043216e64e4579fd899c833ee8eb995fac45da;p=thirdparty%2Flibvirt.git

parallels: don't override error message when XML parsing fails

The virDomainDefParseString method will report a suitable error
on parsing fail, so don't replace that.
---

diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
index 5b04d935fe..0e1dfc5df7 100644
--- a/src/parallels/parallels_driver.c
+++ b/src/parallels/parallels_driver.c
@@ -670,11 +670,8 @@ parallelsDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int
     parallelsDriverLock(privconn);
     if ((def = virDomainDefParseString(xml, privconn->caps, privconn->xmlopt,
                                        1 << VIR_DOMAIN_VIRT_PARALLELS,
-                                       VIR_DOMAIN_XML_INACTIVE)) == NULL) {
-        virReportError(VIR_ERR_INVALID_ARG, "%s",
-                       _("Can't parse XML desc"));
+                                       VIR_DOMAIN_XML_INACTIVE)) == NULL)
         goto cleanup;
-    }
 
     olddom = virDomainObjListFindByUUID(privconn->domains, def->uuid);
     if (olddom == NULL) {