From: RafiBomb <rafi@zurb.com>
Date: Tue, 28 Jun 2016 17:06:25 +0000 (-0700)
Subject: updates block-grid markup migration docs, fixes #347
X-Git-Tag: v2.2.0~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee19bf5c394d36bcd6f48f8336bdc80841694eac;p=thirdparty%2Ffoundation%2Ffoundation-emails.git

updates block-grid markup migration docs, fixes #347
---

diff --git a/docs/pages/migration.md b/docs/pages/migration.md
index d361ef79..16ee0733 100644
--- a/docs/pages/migration.md
+++ b/docs/pages/migration.md
@@ -251,7 +251,7 @@ The block grid has a minor syntax change with identifying the number of elements
 #### New Markup (Plain HTML)
 
 ```
-<table class="row">
+<table class="block-grid up-3">
   <tr>
     <th class="column first">
       Thing 1
@@ -267,11 +267,11 @@ The block grid has a minor syntax change with identifying the number of elements
 #### New Markup (Inky HTML)
 
 ```
-<row small-up="1" large-up="3">
+<block-grid up="3">
   <column>Thing 1</column>
   <column>Thing 2</column>
   <column>Thing 3</column>
-</row>
+</block-grid>
 ```
 
 ---
diff --git a/package.json b/package.json
index 7947dfb0..2a141f80 100644
--- a/package.json
+++ b/package.json
@@ -43,7 +43,7 @@
     "gulp-sourcemaps": "^1.6.0",
     "gulp-wrap": "^0.11.0",
     "gulp-zip": "^3.2.0",
-    "inky": "zurb/inky",
+    "inky": "zurb/inky#fix-character-escaping",
     "lazypipe": "^1.0.1",
     "motion-ui": "^1.1.1",
     "multiline": "^1.0.2",
diff --git a/test/visual/pages/attributes.html b/test/visual/pages/attributes.html
index c400ac0b..8adf1c29 100644
--- a/test/visual/pages/attributes.html
+++ b/test/visual/pages/attributes.html
@@ -2,6 +2,7 @@
   
   <spacer size="32"></spacer>
 
+  the row should have dir="rtl"
   <row dir="rtl">
     <columns large="4" valign="middle" align="center">
       <img class="small-float-center" src="http://placehold.it/300x200/345" alt="">
@@ -22,6 +23,8 @@
     </columns>
   </row>
 
+  the row should have dir="rtl", the columns should have valign and align attributes
+
   <row dir="rtl">
     <columns large="4" valign="middle" align="center">
       <img class="small-float-center" src="http://placehold.it/250/349" alt="">
@@ -31,4 +34,13 @@
       <p style="margin-bottom: 0;" class="text-right subheader">SUBHEADLINE</p>
     </columns> 
   </row> 
+
+  the items should have target="_blank"
+  <center>
+    <menu>
+      <item target="_blank" href="http://zurb.com">Item</item>
+      <item target="_blank" href="http://zurb.com">Item</item>
+      <item target="_blank" href="http://zurb.com">Item</item>
+    </menu>
+  </center>
 </container>