From: Jan Engelhardt <jengelh@medozas.de>
Date: Tue, 1 Mar 2011 01:45:34 +0000 (+0100)
Subject: iptables: fix an inversion
X-Git-Tag: v1.4.11~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee52e00adfb10250e1828b94e43d9482bb201827;p=thirdparty%2Fiptables.git

iptables: fix an inversion

Revisiting the original condition (viewable in git log -1 -p
v1.4.10-57-gacef604), one can notice an unforuntate inversion. This
commit corrects this.

Testcase: -A INPUT -p tcp --dport 1

Reported-by: Florian Westphal
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---

diff --git a/xshared.c b/xshared.c
index b47beb1e..c5a9015d 100644
--- a/xshared.c
+++ b/xshared.c
@@ -87,7 +87,7 @@ static bool should_load_proto(struct iptables_command_state *cs)
 	if (cs->protocol == NULL)
 		return false;
 	if (find_proto(cs->protocol, XTF_DONT_LOAD,
-	    cs->options & OPT_NUMERIC, NULL) != NULL)
+	    cs->options & OPT_NUMERIC, NULL) == NULL)
 		return true;
 	return cs->proto_used;
 }