From: Johannes Schindelin Date: Mon, 22 Jun 2026 08:44:06 +0000 (+0000) Subject: win32: ensure that `localtime_r()` is declared even in i686 builds X-Git-Tag: v2.55.0-rc2~2^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee69d97fa33b620f0fad9d82c87a7e57628a1b0e;p=thirdparty%2Fgit.git win32: ensure that `localtime_r()` is declared even in i686 builds The `__MINGW64__` constant is defined, surprise, surprise, only when building for a 64-bit CPU architecture. Therefore using it as a guard to define `_POSIX_C_SOURCE` (so that `localtime_r()` is declared, among other functions) is not enough, we also need to check `__MINGW32__`. Technically, the latter constant is defined even for 64-bit builds. But let's make things a bit easier to understand by testing for both constants. Making it so fixes this compile warning (turned error in GCC v14.1): archive-zip.c: In function 'dos_time': archive-zip.c:612:9: error: implicit declaration of function 'localtime_r'; did you mean 'localtime_s'? [-Wimplicit-function-declaration] 612 | localtime_r(&time, &tm); | ^~~~~~~~~~~ | localtime_s Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- diff --git a/compat/posix.h b/compat/posix.h index 2f01564b0d..e2e794cad7 100644 --- a/compat/posix.h +++ b/compat/posix.h @@ -56,7 +56,7 @@ # define UNUSED #endif -#ifdef __MINGW64__ +#if defined(__MINGW32__) || defined(__MINGW64__) #define _POSIX_C_SOURCE 1 #elif defined(__sun__) /*