From: Al Viro <viro@zeniv.linux.org.uk>
Date: Sun, 15 Jun 2025 02:01:54 +0000 (+0100)
Subject: selinux: don't bother with selinuxfs_info_free() on failures
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee79ba39b3d6fdcfa53de6519d7e259e284e78f7;p=thirdparty%2Fkernel%2Fstable.git

selinux: don't bother with selinuxfs_info_free() on failures

Failures in sel_fill_super() will be followed by sel_kill_sb(), which
will call selinuxfs_info_free() anyway.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Christian Brauner <brauner@kernel.org>
[PM: subj and description tweaks]
Signed-off-by: Paul Moore <paul@paul-moore.com>
---

diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index 95765374f58d0..9aa1d03ab6120 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -2098,8 +2098,6 @@ err:
 	pr_err("SELinux: %s:  failed while creating inodes\n",
 		__func__);
 
-	selinux_fs_info_free(sb);
-
 	return ret;
 }