From: Volker Lendecke <vl@samba.org>
Date: Thu, 19 Apr 2012 07:51:11 +0000 (+0200)
Subject: s3: Fix Coverity ID 2749: REVERSE_INULL
X-Git-Tag: samba-4.0.0alpha20~186
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee8d55622fa6435ac17befc269daa28f5cfa21dc;p=thirdparty%2Fsamba.git

s3: Fix Coverity ID 2749: REVERSE_INULL
---

diff --git a/source3/smbd/notify_internal.c b/source3/smbd/notify_internal.c
index 4d787436871..27fe21214b3 100644
--- a/source3/smbd/notify_internal.c
+++ b/source3/smbd/notify_internal.c
@@ -388,7 +388,7 @@ static NTSTATUS notify_add_idx(struct db_record *rec, uint32_t vnn)
 
 NTSTATUS notify_remove(struct notify_context *notify, void *private_data)
 {
-	struct server_id pid = messaging_server_id(notify->msg);
+	struct server_id pid;
 	struct notify_list *listel;
 	struct db_record *notify_rec;
 	NTSTATUS status;
@@ -399,6 +399,8 @@ NTSTATUS notify_remove(struct notify_context *notify, void *private_data)
 
 	DEBUG(10, ("notify_remove: private_data=%p\n", private_data));
 
+	pid = messaging_server_id(notify->msg);
+
 	for (listel=notify->list;listel;listel=listel->next) {
 		if (listel->private_data == private_data) {
 			DLIST_REMOVE(notify->list, listel);