From: Nick Porter <nick@portercomputing.co.uk>
Date: Tue, 22 Dec 2020 17:54:47 +0000 (+0000)
Subject: Tidy pair_legacy_tests.c
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee8eb4441037198628f168cd6810b7ae45b22987;p=thirdparty%2Ffreeradius-server.git

Tidy pair_legacy_tests.c
---

diff --git a/src/lib/util/pair_legacy_tests.c b/src/lib/util/pair_legacy_tests.c
index 3e66f93ce27..f4156186f7e 100644
--- a/src/lib/util/pair_legacy_tests.c
+++ b/src/lib/util/pair_legacy_tests.c
@@ -57,7 +57,7 @@ static char const       *dict_dir  = "share/dictionary";
 
 /* Set by pair_tests_init()*/
 static TALLOC_CTX       *autofree;
-static fr_pair_list_t   sample_pairs = NULL;
+static fr_pair_list_t   sample_pairs;
 static char const       *sample_string = "We love Tapioca!";
 
 /*
@@ -190,6 +190,7 @@ static void pair_tests_init(void)
 	if (init_adhoc_attrs(test_dict_attrs) < 0) goto error;
 
 	/* Initialize the "sample_pairs" list */
+	fr_pair_list_init(&sample_pairs);
 	if (load_attr_pairs(&sample_pairs) < 0) goto error;
 }
 
@@ -199,12 +200,10 @@ static void pair_tests_init(void)
 static void test_fr_pair_make(void)
 {
 	fr_pair_t      *vp;
-	fr_cursor_t    cursor;
 	fr_pair_list_t list;
 	TALLOC_CTX     *ctx = talloc_null_ctx();
 
 	fr_pair_list_init(&list);
-	fr_cursor_init(&cursor, &list);
 
 	TEST_CASE("Creating 'vp' using fr_pair_make()");
 	TEST_CHECK((vp = fr_pair_make(ctx, dict_test, &list, "Test-String", sample_string, T_DOUBLE_QUOTED_STRING)) != NULL);