From: Andreas Schneider <asn@samba.org>
Date: Tue, 22 Jun 2021 07:35:47 +0000 (+0200)
Subject: s3:libsmb: Check return code of cli_credentials_guess()
X-Git-Tag: tevent-0.11.0~133
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee9dc1fb47442c6b8839b10be135f2af525fe376;p=thirdparty%2Fsamba.git

s3:libsmb: Check return code of cli_credentials_guess()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/libsmb/auth_generic.c b/source3/libsmb/auth_generic.c
index 59560d677bc..e5120a083a6 100644
--- a/source3/libsmb/auth_generic.c
+++ b/source3/libsmb/auth_generic.c
@@ -64,6 +64,7 @@ NTSTATUS auth_generic_client_prepare(TALLOC_CTX *mem_ctx, struct auth_generic_st
 	struct gensec_settings *gensec_settings;
 	const struct gensec_security_ops **backends = NULL;
 	struct loadparm_context *lp_ctx;
+	bool ok;
 
 	ans = talloc_zero(mem_ctx, struct auth_generic_state);
 	if (!ans) {
@@ -120,7 +121,11 @@ NTSTATUS auth_generic_client_prepare(TALLOC_CTX *mem_ctx, struct auth_generic_st
 		return NT_STATUS_NO_MEMORY;
 	}
 
-	cli_credentials_guess(ans->credentials, lp_ctx);
+	ok = cli_credentials_guess(ans->credentials, lp_ctx);
+	if (!ok) {
+		TALLOC_FREE(ans);
+		return NT_STATUS_INTERNAL_ERROR;
+	}
 
 	talloc_unlink(ans, lp_ctx);
 	talloc_unlink(ans, gensec_settings);