From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 10 Aug 2009 17:14:39 +0000 (+0200)
Subject: request may be NULL
X-Git-Tag: release_2_1_7~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ee9e0521ab065fd41608b04e0db5f61b93df29bf;p=thirdparty%2Ffreeradius-server.git

request may be NULL
---

diff --git a/src/modules/rlm_expr/paircmp.c b/src/modules/rlm_expr/paircmp.c
index 944a62bc9a3..fee7525886e 100644
--- a/src/modules/rlm_expr/paircmp.c
+++ b/src/modules/rlm_expr/paircmp.c
@@ -58,12 +58,16 @@ static int portcmp(void *instance,
 	char buf[MAX_STRING_LEN];
 	char *s, *p, *next;
 	uint32_t lo, hi;
-	uint32_t port = request->vp_integer;
+	uint32_t port;
 
 	instance = instance;
 	check_pairs = check_pairs; /* shut the compiler up */
 	reply_pairs = reply_pairs;
 
+	if (!request) return -1;
+
+	port = request->vp_integer;
+
 	if ((strchr((char *)check->vp_strvalue, ',') == NULL) &&
 			(strchr((char *)check->vp_strvalue, '-') == NULL)) {
 		return (request->vp_integer - check->vp_integer);