From: Gary Lockyer <gary@catalyst.net.nz>
Date: Wed, 14 Nov 2018 01:03:37 +0000 (+1300)
Subject: dsdb group_audit tests: fix use of strncmp
X-Git-Tag: tdb-1.3.17~741
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eea1d4b7782fd2a7741e0c3144900b8b9272bfec;p=thirdparty%2Fsamba.git

dsdb group_audit tests: fix use of strncmp

Replace the uses of:
   strncmp(expected, value, strlen(expected))
With:
    strcmp(expected, value)

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c b/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
index 6ec218beb54..241c0534dae 100644
--- a/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
+++ b/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
@@ -113,6 +113,8 @@ static void _check_group_change_message(
 	json_t *audit = NULL;
 	json_t *v = NULL;
 	const char* value;
+	int cmp;
+
 	json = messages[message];
 
 	/*
@@ -137,7 +139,8 @@ static void _check_group_change_message(
 	}
 
 	value = json_string_value(v);
-	if (strncmp("groupChange", value, strlen("groupChange") != 0)) {
+	cmp = strcmp("groupChange", value);
+	if (cmp != 0) {
 		cm_print_error(
 		    "Unexpected type \"%s\" != \"groupChange\"\n",
 		    value);
@@ -172,7 +175,8 @@ static void _check_group_change_message(
 	}
 
 	value = json_string_value(v);
-	if (strncmp(user, value, strlen(user) != 0)) {
+	cmp = strcmp(user, value);
+	if (cmp != 0) {
 		cm_print_error(
 		    "Unexpected user name \"%s\" != \"%s\"\n",
 		    value,
@@ -190,7 +194,8 @@ static void _check_group_change_message(
 	}
 
 	value = json_string_value(v);
-	if (strncmp(action, value, strlen(action) != 0)) {
+	cmp = strcmp(action, value);
+	if (cmp != 0) {
 		print_error(
 		    "Unexpected action \"%s\" != \"%s\"\n",
 		    value,