From: Daniel Salzman <daniel.salzman@nic.cz>
Date: Mon, 30 Jun 2025 04:52:46 +0000 (+0200)
Subject: requestor: avoid calling close(-1) (Coverity)
X-Git-Tag: v3.5.0~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eec9afaa65f6053dcfdb4778ac1dbb00dea9cdac;p=thirdparty%2Fknot-dns.git

requestor: avoid calling close(-1) (Coverity)
---

diff --git a/src/knot/query/requestor.c b/src/knot/query/requestor.c
index 2a117162bd..50b1675ad8 100644
--- a/src/knot/query/requestor.c
+++ b/src/knot/query/requestor.c
@@ -397,7 +397,7 @@ static int request_produce(knot_requestor_t *req, knot_request_t *last,
 	}
 
 	if (req->layer.state == KNOT_STATE_CONSUME) {
-		if ((last->flags & KNOT_REQUEST_NEW) &&
+		if ((last->flags & KNOT_REQUEST_NEW) && (last->fd >= 0) &&
 		    !(last->flags & (KNOT_REQUEST_UDP | KNOT_REQUEST_TLS))) {
 			close(last->fd);
 			last->fd = -1;