From: Willem Toorop <willem@nlnetlabs.nl>
Date: Wed, 19 Nov 2014 15:37:36 +0000 (+0100)
Subject: bugfix #697: Double free with ldns-dane create
X-Git-Tag: release-1.7.0-rc1~123
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=eef606c051cc73dcac9b324e70eb6960019a8e7b;p=thirdparty%2Fldns.git

bugfix #697: Double free with ldns-dane create

Thanks Carsten Strotmann
---

diff --git a/Changelog b/Changelog
index 0b2b160d..4e350ba2 100644
--- a/Changelog
+++ b/Changelog
@@ -34,6 +34,8 @@ TBD
 	  terminals.  Thanks Stuart Browne
 	* bugfix #605: Determine default trust anchor location at compile time
 	  Thanks Peter Koch
+	* bugfix #697: Double free with ldns-dane create
+	  Thanks Carsten Strotmann
 
 1.6.17	2014-01-10
 	* Fix ldns_dnssec_zone_new_frm_fp_l to allow the last parsed line of a
diff --git a/examples/ldns-dane.c b/examples/ldns-dane.c
index d35099be..8d8c2749 100644
--- a/examples/ldns-dane.c
+++ b/examples/ldns-dane.c
@@ -1071,7 +1071,7 @@ dane_create(ldns_rr_list* tlsas, ldns_rdf* tlsa_owner,
 			selected_cert);
 	LDNS_ERR(s, "could not create tlsa rr");
 
-	ldns_rr_set_owner(tlsa_rr, tlsa_owner);
+	ldns_rr_set_owner(tlsa_rr, ldns_rdf_clone(tlsa_owner));
 			     
 	if (! ldns_rr_list_contains_rr(tlsas, tlsa_rr)) {
 		if (! ldns_rr_list_push_rr(tlsas, tlsa_rr)) {